Skip to content

Refactor: Add IsDisposed property to IShellPage and check before updating #17320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Observed the reported issue in Sentry: FILES-APP-23K.
  2. Verified that the fix addresses the issue by preventing ContentPageContext.Update() from accessing disposed ShellPage properties after navigation.
  3. Confirmed that the IsDisposed property is correctly set in BaseShellPage.
  4. Ensured that the check for ShellPage.IsDisposed in ContentPageContext.Update prevents updates after the page has been disposed.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 505535

Not quite right? Click here to continue debugging with Seer.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very confident, but I don't think this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant