Skip to content

Feat: Reuse MediaPreview instance in InfoPane #17313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. The issue was that: Rapid media file selection creates new MediaSource objects, accumulating memory faster than garbage collection can reclaim, causing an OutOfMemoryException.
  2. Reuse the existing MediaPreview instance instead of creating a new one every time the selected item changes.
  3. Added UpdateViewModelAsync method to MediaPreview to update the view model and reload the media.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 505484

Not quite right? Click here to continue debugging with Seer.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fix makes sense, and it causes the preview will no longer function properly.
I will prepare an alternative fix.

@yaira2 yaira2 closed this Jul 28, 2025
@yaira2 yaira2 deleted the seer/reuse-mediapreview branch July 28, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants