Skip to content

Fix: Fixed an issue where tags would sometimes display with the wrong color #16603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Dec 13, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open a folder containing some tagged items
  2. Change sort order
  3. Then, check that tag icons in the following controls are using the appropiate color : Settings/Tags, Sidebar>Tags, Home>Tags Widget, Preview Pane, Right click context menu

Notes
I changed the bindings (I think we may remove that VisualState - our DependencyProperty doesn't seem to be bindable).
I don't know if this is the appropriate way to address the issue

@yaira2 yaira2 changed the title Fix: Tag icons may use the wrong color Fix: Fixed an issue where tags would sometimes display with the wrong color Dec 15, 2024
@yaira2 yaira2 requested a review from 0x5bfa December 15, 2024 02:59
@ferrariofilippo ferrariofilippo marked this pull request as draft December 15, 2024 10:19
@ferrariofilippo ferrariofilippo marked this pull request as ready for review December 15, 2024 10:50
@0x5bfa
Copy link
Member

0x5bfa commented Dec 16, 2024

I think you don't need newValue parameter, just use DP value. Otherwise, looks good code wise.

@yaira2 yaira2 merged commit 6089e6f into files-community:main Dec 17, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 17, 2024
@ferrariofilippo ferrariofilippo deleted the bug_tag_colors branch December 19, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tag icons in the details layout may use the wrong color
3 participants