Skip to content

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 11, 2025

Ref: filecoin-project/ref-fvm#2101

This is a draft, but the ExecutionEvent::Log could probably be done separately since that's much more likely to actually make it in. I'll do that if I end up bailing on this.

rvagg added a commit to filecoin-project/lotus that referenced this pull request Jan 11, 2025
* Plumb through dump_cache from fvm4 to access intermediate blocks:
  - filecoin-project/filecoin-ffi#512
  - filecoin-project/ref-fvm#2101
* Enable cache dumping in StateReplay with LOTUS_REPLAY_DUMP_CACHED_BLOCKS
* Add optional "Blocks" field InvocResult
* Handle ExecutionEvent::Log's and add "Logs" field to ExecutionTrace
* Dump intermediate cache blocks to CAR in /tmp when they appear while using
  `lotus-shed msg --exec-trace`.
@rvagg rvagg force-pushed the rvagg/dump-cache branch 2 times, most recently from 01b4772 to 285faf5 Compare March 28, 2025 08:30
rvagg added a commit to filecoin-project/lotus that referenced this pull request Mar 28, 2025
* Plumb through dump_cache from fvm4 to access intermediate blocks:
  - filecoin-project/filecoin-ffi#512
  - filecoin-project/ref-fvm#2101
* Enable cache dumping in StateReplay with LOTUS_REPLAY_DUMP_CACHED_BLOCKS
* Add optional "Blocks" field InvocResult
* Handle ExecutionEvent::Log's and add "Logs" field to ExecutionTrace
* Dump intermediate cache blocks to CAR in /tmp when they appear while using
  `lotus-shed msg --exec-trace`.
@rvagg rvagg force-pushed the rvagg/dump-cache branch from 02f2556 to 444583a Compare April 3, 2025 07:11
rvagg added a commit to filecoin-project/lotus that referenced this pull request Apr 3, 2025
* Plumb through dump_cache from fvm4 to access intermediate blocks:
  - filecoin-project/filecoin-ffi#512
  - filecoin-project/ref-fvm#2101
* Enable cache dumping in StateReplay with LOTUS_REPLAY_DUMP_CACHED_BLOCKS
* Add optional "Blocks" field InvocResult
* Handle ExecutionEvent::Log's and add "Logs" field to ExecutionTrace
* Dump intermediate cache blocks to CAR in /tmp when they appear while using
  `lotus-shed msg --exec-trace`.
@rvagg rvagg changed the title feat: support DumpCache, handle Logs in traces feat: support flush_all_blocks, handle new ipld operations in traces Apr 3, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Apr 3, 2025
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable approach. It's a little annoying that we're losing the ordering of log statements, IPLD events, etc. but that's a limit of the current execution trace format and changing that will be a larger breaking change.

@rvagg
Copy link
Member Author

rvagg commented Apr 8, 2025

Will leave this one alone until we have a release to use that incorporates it.

@Stebalien Stebalien marked this pull request as ready for review April 11, 2025 14:18
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Apr 11, 2025
@rvagg rvagg merged commit f520d39 into master Apr 14, 2025
5 checks passed
@rvagg rvagg deleted the rvagg/dump-cache branch April 14, 2025 03:14
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants