Skip to content

Conversation

@snadrus
Copy link
Contributor

@snadrus snadrus commented Oct 30, 2025

what do you think?
Right now it's PdpV1. Should we build something similar for PdpV0 ?

Returned to draft: GOTEXT is failing to get the translation data. Translations are missing.

@snadrus snadrus requested a review from LexLuthr October 30, 2025 23:13
@snadrus snadrus requested a review from a team as a code owner October 30, 2025 23:13
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some screenshots would be nice for this! Looks very useful. When backporting to pdpv0 we can also add PDP registration to the step.

@snadrus snadrus requested a review from LexLuthr November 3, 2025 23:46
@snadrus snadrus marked this pull request as draft November 7, 2025 23:41
@snadrus snadrus marked this pull request as ready for review November 8, 2025 03:01
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we choose either storage or pdp and it seems to exit from there. Can we loop back to optional menu to avpid running guided-setup multiple times. Or just add storage setup to end of PDP. Basically, this should be a 1 step process.

@snadrus
Copy link
Contributor Author

snadrus commented Nov 10, 2025

I see that we choose either storage or pdp and it seems to exit from there. Can we loop back to optional menu to avpid running guided-setup multiple times. Or just add storage setup to end of PDP. Basically, this should be a 1 step process.

I do that here:

@snadrus snadrus merged commit c377ec6 into main Nov 10, 2025
17 checks passed
@snadrus snadrus deleted the guided-pdp branch November 10, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants