-
Notifications
You must be signed in to change notification settings - Fork 32
webui: Content page #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
webui: Content page #715
Conversation
19cfe78 to
e45fac2
Compare
e45fac2 to
acd467c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a small fix to show pieceCIDv2 instead of v1 or maybe both. I mean pieceInfo page which this will link to will already show both so maybe just v2.
| off, err := a.deps.IndexStore.GetOffset(ctx, offset.PieceCidV2, mh) | ||
| if err != nil { | ||
| res = append(res, ContentInfo{ | ||
| PieceCID: offset.PieceCidV2.String(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should convert this to pieceCID v2. Since all UI links are exclusively using pieceCID v2, this will break compatibility.
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <title>Content</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Content" seems like a place-holder term.
IPFS Tools ?
Raw data locator?
Maybe add a descriptive section here for convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't have a better idea. I think eventually we want this to apply to all hosted content + allow for deeper automated inspections (e.g have a world-ping button to understand external view)
Basic content lookup/preview feature to find which pieces CIDs are in. Useful for debugging retrievability issues.
Later we can extend this page with nicer features like dumping IPLD schema, links, content type guessing, maybe sandboxed preview (basically porting dag.parts features), IPNI lookup check, etc.
@LexLuthr can you confirm this is also compatible with PDP?