Create a FIP Editor Handbook for current and intending FIP Editors #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckyparadise
requested review from
jennijuju,
anorth,
jsoares,
TippyFlitsUK,
momack2 and
rvagg
as code owners
jsoares
approved these changes
Jan 19, 2025
FIP Editor Handbook/README
Outdated
|
|
||
| For pull requests (PRs) that impact **protocol design/specifications** or include **considerations** affecting the protocol: | ||
|
|
||
| - FIP Editors must ensure **at least two appropriate technical reviews and approvals** have been obtained before considering the PR ready to merge. |
There was a problem hiding this comment.
Is the sole difference between these and the ones below the inclusion of "appropriate"? I thought you were going for the "technical".
I'm not sure "appropriate" is well-defined enough for this to make a difference.
lanzafame
reviewed
Jan 20, 2025
lanzafame
reviewed
Jan 23, 2025
BigLep
reviewed
Jan 24, 2025
| - Be interested in participating in governance. | ||
| - Be skilled in using GitHub. | ||
|
|
||
| Continued inability to meet these requirements may lead to removal from the position. Interested candidates can apply by completing [this form]. Current FIP Editors will review membership requests. |
There was a problem hiding this comment.
Is there a link to the form someone submits? Are we actually going to make and maintain a form? Given how low volume this will be, is it better to create a mailing list (e.g., [email protected]) that contacts all the FIP editors and they handle from there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To further expand the roles, responsibilities, and expectations for FIP Editors. I have written a handbook to form an extended guide for current and intending FIP Editors.
Feedback is welcome.