support suite-based queueing #47
Open
+1,316
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ebarajas
force-pushed
the
ebarajas/10-01-support_suite-based_queueing
branch
3 times, most recently
from
243cd93 to
ee83285
Compare
ebarajas
force-pushed
the
ebarajas/support-ordering-strategies
branch
from
9a1776f to
2818672
Compare
ebarajas
force-pushed
the
ebarajas/10-01-support_suite-based_queueing
branch
from
57648bc to
5f85a15
Compare
yfang-figma
reviewed
Oct 3, 2025
|
|
||
| # Separate chunks from individual tests | ||
| chunks = executables.select { |e| e.is_a?(CI::Queue::TestChunk) } | ||
| individual_tests = executables.select { |e| !e.is_a?(CI::Queue::TestChunk) } |
There was a problem hiding this comment.
Conceptually, wondering if we should just stop using individual tests as a first class element in the queue, and just always use TestChunk. (An individual test can also be wrapped into a TestChunk).
There was a problem hiding this comment.
The benefit is whenever we interact with an item from the queue, we have a single interface to deal with.
| @index = tests.map { |t| [t.id, t] }.to_h | ||
| tests = Queue.shuffle(tests, random, config: config) | ||
| push(tests.map(&:id)) | ||
| executables = Queue.shuffle(tests, random, config: config) |
There was a problem hiding this comment.
nit: I think "shuffle" (and the underlying "order_tests") now does more than reordering. Maybe we should rename this?
Or maybe separate to two function calls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Added a new
suite_bin_packingtest ordering strategy that groups tests by suite and optimizes execution time.What changed?
SuiteBinPackingstrategy that groups tests by test suite and creates "chunks" for executionTestChunkclass to represent groups of tests that should be executed togetherThe strategy uses test timing data to: