Skip to content

Added support for db migrations #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

manjeet-fetchai
Copy link

@manjeet-fetchai manjeet-fetchai commented Dec 6, 2022

Added support for db migrations:

  • Assuming DATABASE_URL, SHADOW_DATABASE_URL, ROOT_DATABASE_URL variables would be created by startup script internally using the available environment variables
    Ref: 787a833

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Either the PR references an issue (via the "Development" combobox) or the description explains the need for the changes.
  • The PR appropriately sized.
  • The PR contains an idempotent DB migration.
  • I have verified the correctness of the DB migration using relevant data (e.g. test-generated data).
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@manjeet-fetchai manjeet-fetchai marked this pull request as draft December 6, 2022 00:21
Comment on lines +11 to +12
SHADOW_DATABASE: {{ .Values.db.shadowDatabase | quote }}
ROOT_DATABASE: {{ .Values.db.rootDatabase | quote

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually shouldn't need these in production. These are only needed for resetting the DB or committing migrations. We should only ever be applying migrations in production which only interacts with DB_DATABASE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants