Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Response handler submessages and Role management improvements #9

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: Response handler submessages and Role management improvements #9

wants to merge 15 commits into from

Conversation

MissingNO57
Copy link
Collaborator

No description provided.

@MissingNO57 MissingNO57 changed the title feat: Response handler submessages feat: Response handler submessages and Role management improvements Feb 3, 2025
pbukva
pbukva reviewed Feb 3, 2025
View reviewed changes
src/access_control/role.rs Outdated Show resolved Hide resolved
pbukva
pbukva requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@pbukva pbukva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I would suggest a little bit of renaming:
    give -> grant
    take -> revoke

  2. Also please implement the dedicated renounce role functionality as dedicated function, which allows any account which already has the role to remove itself from that role, hence the renounce term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbukva pbukva pbukva requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MissingNO57 @pbukva