fix(cli-generator): drop third-party rust setup action from generated ci.yml - #17507
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
fix(cli-generator): drop third-party rust setup action from generated ci.yml#17507devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
… ci.yml Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The generated
ci.ymlusedactions-rust-lang/setup-rust-toolchain@v1. Orgs that allowlist first-party actions only cannot run it, and an unrunnable action fails the workflow before any job starts — leaving no option but to fernignoreci.ymland hand-maintain it, which also means the generated npm publish jobs never land. Replaces it with a first-party equivalent, and fixes a second gap found while diffing a hand-maintainedci.ymlagainst ours: the generated crates' tests never ran.Changes Made
All 8 uses of the third-party action (check, compile, test, version, and the 5 publish matrix legs) are now a shell step that uses the runner's preinstalled cargo, with a rustup fallback for containers/self-hosted runners — the same step cargo-dist emits into
release.yml. The publish matrix keeps itsrustup target add ${{ matrix.rust-target }}, which the action did via itstargetinput.Caching came from that action wrapping
Swatinem/rust-cache, so~/.cargoandtarget/are now cached withactions/cache@v4instead, keyed per job and per rust target (target/holds per-triple output, so the five cross-compiles must not share one entry).The
testjob now tests the generated crates by manifest path:patchCargoTomlwires those crates in as path dependencies, not workspace members, andcargo testonly builds test targets for the packages it is invoked on — so the serialization tests shipped with every generated CLI have never executed in CI. Nested type-partition crates get a step too, since they are path dependencies of the types facade rather than members of it. Emitted for both the build-only and publish-enabled workflow forms.No config surface, no change to job names, the job graph, the publish matrix, the version guard, OIDC/token handling,
release.yml, or any generated Rust source.Testing
emitPublishWorkflow.test.tsasserts no non-actions/*action reappears in either emitted form, covers the cache paths/keys, and covers the manifest-path steps (present when crates are passed, absent otherwise). 422 generator tests pass.ci.ymlfor an ElevenLabs-shaped config, parsed it as YAML, and confirmed thetestjob's step list and the absence ofactions-rust-lang/.Link to Devin session: https://app.devin.ai/sessions/0c32af0182744cbe8d22f33a85a93160