Skip to content

chore(rust): tag optional request body snippet tests as slow - #17501

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1787325084-rust-snippets-slow-tag
Closed

chore(rust): tag optional request body snippet tests as slow#17501
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1787325084-rust-snippets-slow-tag

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

@fern-api/rust-dynamic-snippets#test fails in CI whenever the turbo cache misses: two of the four tests in OptionalRequestBody.test.ts exceed vitest's 5s default timeout because each test builds a dynamic snippets generator that loads and parses respect-optional-request-body.json from disk. The test bodies take ~220ms locally, so the failure is cold-start/IO latency on the runner, not a behavior regression.

This tags the describe block with slow, the repo's existing convention (packages/configs/vitest/base.mjs gives that tag a 30s timeout), matching how packages/generator-cli handles its heavy-IO tests.

Changes Made

  • describe("optional request body", { tags: ["slow"] }, ...) in generators/rust/dynamic-snippets/src/__test__/OptionalRequestBody.test.ts

No changelog: test-only, no generator output changes.

Testing

Link to Devin session: https://app.devin.ai/sessions/3783789dffe246c9871ebfbf25897445


Open in Devin Review

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot changed the title test(rust): tag optional request body snippet tests as slow chore(rust): tag optional request body snippet tests as slow Aug 21, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@github-actions

Copy link
Copy Markdown
Contributor

SDK Generation Benchmark Results

Comparing PR branch against median of 5 nightly run(s) on main (latest: 2026-08-21T04:13:10Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
rust-sdk square 228s (n=5) 224s (n=5) 177s -51s (-22.4%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-08-21T04:13:10Z). Trigger benchmark-baseline to refresh.
Last updated: 2026-08-21 15:20 UTC

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Superseded: main now carries the same { tags: ["slow"] } change (with an explanatory comment), so this branch rebases to an empty diff. Closing.

Written by Devin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant