build(deps): bump golang.org/x/mod from 0.24.0 to 0.39.0 in /generators/go - #17396
build(deps): bump golang.org/x/mod from 0.24.0 to 0.39.0 in /generators/go#17396dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.24.0 to 0.39.0. - [Commits](golang/mod@v0.24.0...v0.39.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.39.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
AI Review Summary
Dependabot bump of golang.org/x/mod 0.24.0 → 0.39.0, which pulls x/tools to 0.48.0 and — more notably — raises the module's go directive from 1.23.0 to 1.25.0. The checksum changes look consistent. The only real review item is the toolchain floor bump.
- 🟡 1 warning(s)
| module github.com/fern-api/fern-go | ||
|
|
||
| go 1.23.0 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🟡 warning
This bump silently raises the minimum Go toolchain from 1.23 to 1.25 (required by x/mod v0.39.0). Confirm CI runners, Dockerfiles, and any downstream consumers of the generated code / this module are on Go ≥1.25 before merging — otherwise builds will fail with a toolchain error rather than a nice message. If the generated SDKs inherit this floor, that's a user-facing compatibility change for a dependency bump PR.
SDK Generation Benchmark ResultsComparing PR branch against median of 5 nightly run(s) on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
|
Superseded by #17491. |
Pull request was closed
Bumps golang.org/x/mod from 0.24.0 to 0.39.0.
Commits
13be902go.mod: update golang.org/x dependencies792ac16go.mod: update golang.org/x dependenciesfe2ec04all: fix some comments to improve readabilitydeb1dfcgo.mod: update golang.org/x dependencies087f651modfile: use slices.Backward343ee60x/mod: allow for aggressively conslidating requires643da9bgo.mod: update golang.org/x dependenciesccc3cdfzip: include 'but content has correct sum' note in TestVCSab30318zip: update zip hashes for new flate compression03901d3go.mod: update golang.org/x dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)