Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft of implementing #596 #597

Merged
merged 5 commits into from
Feb 4, 2025
Merged

draft of implementing #596 #597

merged 5 commits into from
Feb 4, 2025

Conversation

marcmengel
Copy link
Contributor

So this adds a --managed-token flag to jobsub_submit, which suppresses calling condor_vault_storer when we have
recently called it for this oauth_handle/token scope hash and this schedd.

@shreyb shreyb linked an issue Jan 30, 2025 that may be closed by this pull request
@shreyb shreyb requested review from cathulhu and shreyb January 30, 2025 21:51
lib/condor.py Outdated Show resolved Hide resolved
lib/get_parser.py Outdated Show resolved Hide resolved
lib/condor.py Outdated Show resolved Hide resolved
lib/condor.py Outdated Show resolved Hide resolved
lib/condor.py Outdated Show resolved Hide resolved
lib/condor.py Outdated Show resolved Hide resolved
lib/condor.py Outdated Show resolved Hide resolved
@shreyb shreyb removed the request for review from cathulhu January 31, 2025 15:43
lib/condor.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@shreyb shreyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. @DrDaveD - any further comments?

ETA: Dave indicated offline that he approved this PR.

@shreyb shreyb added this to the 1.10 milestone Jan 31, 2025
@shreyb shreyb merged commit 629e816 into master Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce calls to vault for token weakening...
3 participants