Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout parameter has been made configurable. Issue: #117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Timeout parameter has been made configurable. Issue: #117

wants to merge 2 commits into from

Conversation

brngylni
Copy link
Contributor

@brngylni brngylni commented Mar 9, 2024 •
edited
Loading

The request timeout parameter has been made configurable in order to make it usable on different network conditions.

Regarding issue: #31

@onuralpszr onuralpszr self-requested a review March 9, 2024 18:49
@onuralpszr onuralpszr added enhancement New feature or request good first issue Good for newcomers labels Mar 9, 2024
@gridhead
Copy link
Member

@brngylni Could you please fix the testcases?

@brngylni
Copy link
Contributor Author

@brngylni Could you please fix the testcases?

Check please

#118 (comment)

@gridhead
Copy link
Member

@brngylni The test cases for this pull request would be separate as compared to the one for #118

@brngylni
Copy link
Contributor Author

@brngylni The test cases for this pull request would be separate as compared to the one for #118

Any hint would be helpful since I am having the same struggle with #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onuralpszr onuralpszr Awaiting requested review from onuralpszr

Assignees

@brngylni brngylni

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brngylni @gridhead @onuralpszr