rewrite #10
rewrite #10
Conversation
There was a problem hiding this comment.
Did you try to build using nix? Don't have time rn, but would be cool if you could take a look at elsirion/nix-bitcoin@6890ee5 and how it works.
| return render_template('index.html', name='justin', | ||
| invoice=invoice, pay_result=pay_result, connect_str=connect_str) | ||
|
|
||
| from app import app |
There was a problem hiding this comment.
Would be good to have something like the following here:
if __name__ == "__main__":
app.run(port = 3000)so that it can be started without some weird other component I never got to run on Nix (I know you aren't supposed to, but don't want to waste more time on this).
There was a problem hiding this comment.
I was passing the port in as an option because the default port was conflicting with fedimint (5000)
Yes I can take a look at the nix and get it to work.
There was a problem hiding this comment.
An option would be great! This is just what I did so far.
|
Scanner needs fixing |
| import os | ||
|
|
||
| class Config(object): | ||
| SECRET_KEY = os.environ.get('SECRET_KEY') or 'you-will-never-guess' |
There was a problem hiding this comment.
I don't think this is needed because you aren't using the session at all
| RPC_SOCKET = os.environ.get('RPC_SOCKET') or 'you-will-never-guess' | ||
| CONNECT_INFO = os.environ.get('CONNECT_INFO') or 'you-will-never-guess' |
There was a problem hiding this comment.
The app should probably fail if these aren't set. It just won't work. So let's not set defaults here.
There was a problem hiding this comment.
It does fail, the or syntax doesn't work. Defaults have to be given to get as a second argument.
| <img style="height: 200px; width: 200px;" src="{{ qrcode(connect_str) }}"> | ||
| <br> | ||
| <pre>{{ connect_str }}</pre> | ||
| <br> |
There was a problem hiding this comment.
Please add some description back in about what this is and how to use it.
|
|
||
|
|
||
| @app.route('/') | ||
| @app.route('/index') |
There was a problem hiding this comment.
why make this also /index?
| from json2html import * | ||
|
|
||
| rpc = LightningRpc(os.environ['RPC_SOCKET']) | ||
| connect_str = os.environ['CONNECT_INFO'] |
There was a problem hiding this comment.
should come from config instead
Rewrote the whole thing, if this seems unsuitable I can keep it as is and put in changes to existing.
The reason for the rewrite was that I had too many weird errors while working with the site and I had to look up how to make a flask project.