Add tests for fractionation module #279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
force-pushed
the
test_fractionating
branch
from
2aef263 to
e9ac63a
Compare
schmoelder
reviewed
Jun 12, 2025
| """Class to create a faked SolutionIO object with a Gauss function.""" | ||
|
|
||
| def __init__(self, solution_struct, comp_system): | ||
| """solution struct has to be a dictionary with |
schmoelder
reviewed
Jun 12, 2025
| ) | ||
|
|
||
|
|
||
| class GaussianPulse(SolutionIO): |
Contributor
There was a problem hiding this comment.
Wouldn't it make sense to update the solution fixtures in test_solution.py?
schmoelder
reviewed
Jun 12, 2025
Contributor
There was a problem hiding this comment.
Consider a different name. "Fractionating" is not a really a thing. Consider what exactly you are testing here. Is it the FractionationOptimizer? Is it performance?
schmoelder
reviewed
Jun 12, 2025
Contributor
There was a problem hiding this comment.
Does this make the optimization more robust or is this just "to play around"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Cases i used for the fractionating topic as test to have a small suit that checks wheter the standard
fractionoptimizerand it's default parameter are suitable. Hopefully this shows possible instabilities with the cobyla optimizer when changing parameters.I guess the cobyla fixture is a litle bit messy.
Also changed the parameters for tol and rhoberg another time.