DT-340: Warn the user if they are leaving a story edit page with unsaved changes #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r if there are unsaved edits
…from an unsaved edited story
…e form existed. Also created a function to add and remove the beforeunload event listener
JuanVqz
reviewed
Jan 10, 2025
Comment on lines
+53
to
+60
| if (!confirmLeave) { | ||
| // Prevent navigation if the user chooses not to leave | ||
| event.preventDefault(); | ||
| } else { | ||
| // Optionally, reset isDirty if leaving | ||
| isDirty = false; | ||
| addBeforeUnloadEventListener(isDirty) | ||
| } |
There was a problem hiding this comment.
I find it easier to read confirmLeave compared to !confirmLeave, as it always takes me a moment to grasp the condition.
Suggested change
| if (!confirmLeave) { | |
| // Prevent navigation if the user chooses not to leave | |
| event.preventDefault(); | |
| } else { | |
| // Optionally, reset isDirty if leaving | |
| isDirty = false; | |
| addBeforeUnloadEventListener(isDirty) | |
| } | |
| if (confirmLeave) { | |
| // Optionally, reset isDirty if leaving | |
| isDirty = false; | |
| addBeforeUnloadEventListener(isDirty) | |
| } else { | |
| // Prevent navigation if the user chooses not to leave | |
| event.preventDefault(); | |
| } |
| } | ||
| } | ||
|
|
||
| function warnUserifUnsavedEdits(event) { |
There was a problem hiding this comment.
A bit picky, you might missed the I should go in uppercase.
Suggested change
| function warnUserifUnsavedEdits(event) { | |
| function warnUserIfUnsavedEdits(event) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
https://ombulabs.atlassian.net/browse/DT-340
Motivation / Context
Currently if you leave the current page, you can lose information that was not saved. This feature warns you if you are leaving without saving information.
QA / Testing Instructions
Screenshots:
I will abide by the code of conduct.