Repository navigation
Add --offline to bundle_report compatibility - #201
Merged
Merged
Conversation
The compatibility report looks up every incompatible gem's released versions on rubygems.org to find one that allows the target Rails. Without network (CI runners, locked-down machines) the report cannot run at all, even though the list of incompatible gems only needs the gemspecs already installed. --offline skips that lookup and lists the incompatible gems on their own. outdated and ruby_check always call rubygems.org, so the flag is refused there instead of being silently ignored.
JuanVqz
marked this pull request as ready for review
October 12, 2026 21:01
JuanVqz
force-pushed
the
feature/bundle-report-offline
branch
from
October 12, 2026 21:04
921b650 to
8b13163
Compare
OptionParser accepts any unique prefix of a long option, so `outdated --off` ran the outdated report with the flag silently ignored: the check only looked for the exact "--offline".
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can check the
lockfiles for the versions that are not compatible and make the operation faster, and according to the app, this might be useful if someone doesn't have an internet connection or so.Yes, we don't suggest what is the target version but something is something even with no internet connection.