STJ-23: BUGFIX: deprecation_tracker breaking with unknown keywords #157 #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etagwerker
approved these changes
May 29, 2025
etagwerker
requested changes
May 29, 2025
lib/deprecation_tracker.rb
Outdated
| super(*messages, **keyword_args, **kwargs) | ||
| rescue ArgumentError | ||
| super(*messages, **keyword_args) | ||
| end |
There was a problem hiding this comment.
@julioalucero if you know when the signature of the method changed, it would be best to use if/else vs. begin/rescue
|
@etagwerker, adding the changelog like this is ok? 99576c2 |
etagwerker
approved these changes
May 30, 2025
There was a problem hiding this comment.
@julioalucero You can add a line like this one to the CHANGELOG and we should be all good to go: 3d35c23#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR4
@etagwerker added! Thanks for the review! |
etagwerker
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STJ-23: BUGFIX: deprecation_tracker breaking with unknown keywords
Description
BUGFIX: Prevent DeprecationTracker from crashing when receiving unknown keyword arguments.
In certain environments (e.g. when using sass-embedded), the warn method receives unexpected keyword arguments such as :deprecation, :span, or :stack. Previously, these unrecognized keywords would raise an ArgumentError and interrupt execution. This patch safely handles unknown keyword arguments while preserving known ones.
Motivation and Context
Fixes #152 — DeprecationTracker was breaking during setup in projects using sass-embedded due to unhandled keyword arguments in warn.
This update ensures that warn forwards all known and unknown keyword arguments safely to super, and gracefully falls back to known keywords if the parent method does not accept extras.
How Has This Been Tested?
Screenshots:
I will abide by the code of conduct