Skip to content

Qonnx binary quant dev #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

jmitrevs
Copy link
Contributor

@jmitrevs jmitrevs commented Aug 4, 2025

Description

This is an further work on PR #1292: Added a transformation for the QONNX operator BipolarQuant to hls4ml operator BinaryQuantizer.

  • Added a ONNX BipolarQuant Operator.
  • Added three transformations (optimizations) that transform the qonnx operator to an hls4ml operator.

Adding those changes showed issues in hls4ml binary handling, that this PR continues to fix.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

This PR includes the BipolarQuant tests added to test_qonnx.py from the original PR (PR #1292).

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

jvreca and others added 22 commits April 28, 2025 16:16
…is not applicable for BinaryQuantizer since it does not have a scaling factor
…zations, since it was already removed."

This reverts commit 89e2136.
@jmitrevs jmitrevs mentioned this pull request Aug 4, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants