Skip to content

Fixes to vCPU-ms test #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

Fixes to vCPU-ms test #1183

merged 5 commits into from
Jun 11, 2025

Conversation

cceckman-at-fastly
Copy link
Collaborator

Fixes and tweaks for the get-vcpu-ms test, which was failing in CI for the unrelated #1182.

  • Use more verbose failure in get-vcpu-ms test, so we know which assertion failed
  • Formatting fixes, because I don't know JS style
  • Fix spacing around truthy debug message, because it put the space in the wrong place
  • Weaken assertion around vCPU startup time: >=0, not >0, because apparently the runtime's startup is so good now that this assertion fails

dgohman-fastly
dgohman-fastly reviewed Jun 11, 2025
View reviewed changes
dgohman-fastly
dgohman-fastly approved these changes Jun 11, 2025
View reviewed changes
Copy link

@dgohman-fastly dgohman-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this codebase specifically, but these changes look reasonable to me.

@cceckman-at-fastly cceckman-at-fastly merged commit 7f2a6b7 into main Jun 11, 2025
28 checks passed
@cceckman-at-fastly cceckman-at-fastly deleted the cceckman/vcpu-fixen branch June 11, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgohman-fastly dgohman-fastly dgohman-fastly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cceckman-at-fastly @dgohman-fastly