Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relabel build scripts and add a 'clean' script #1099

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Relabel build scripts and add a 'clean' script #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e0dcf
Relabel npm scripts
harmony7 Jan 30, 2025
2c0fd85
Add clean and build scripts
harmony7 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ jobs:
key: crate-cache-wasm-tools-${{ env.wasm-tools_version }}
- name: Build
if: matrix.profile == 'release'
run: npm run build
run: npm run build:release
- name: Build
if: matrix.profile == 'weval'
run: npm run build:weval
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
key: crate-cache-wasm-tools-${{ env.wasm-tools_version }}
- name: Build
if: ${{ matrix.profile == 'release' }}
run: npm run build
run: npm run build:release
- name: Build
if: ${{ matrix.profile == 'debug' }}
run: npm run build:debug
Expand Down
4 changes: 2 additions & 2 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ To build from source, you need to have the following tools installed to successf

Build the runtime using npm:
```sh
npm run build && npm run build:debug && npm run build:weval
npm run build
```

#### macOS (Apple silicon)
Expand Down Expand Up @@ -105,7 +105,7 @@ npm run build && npm run build:debug && npm run build:weval

Build the runtime using npm:
```sh
npm run build && npm run build:debug && npm run build:weval
npm run build
```

## Testing a Local build in a Compute application
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@
"test:wpt": "tests/wpt-harness/build-wpt-runtime.sh && node ./tests/wpt-harness/run-wpt.mjs -vv",
"test:wpt:debug": "tests/wpt-harness/build-wpt-runtime.sh --debug-build && node ./tests/wpt-harness/run-wpt.mjs -vv",
"test:types": "tsd",
"build": "./runtime/fastly/build-release.sh",
"clean": "rm -f starling.wasm fastly.wasm fastly.debug.wasm fastly-weval.wasm fastly-ics.wevalcache fastly-js-compute-*.tgz",
"build": "npm run clean && npm run build:release && npm run build:debug && npm run build:weval",
"build:release": "./runtime/fastly/build-release.sh",
"build:debug": "./runtime/fastly/build-debug.sh",
"build:weval": "./runtime/fastly/build-release-weval.sh",
"build:debug:info": "./runtime/fastly/build-debug.sh --keep-debug-info",
Expand Down
2 changes: 1 addition & 1 deletion tests/wpt-harness/run-wpt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ trap 'rm $output' EXIT

echo "Building the runtime..."
cd "$root"
if ! npm run build > "$output" 2>&1; then
if ! npm run build:release > "$output" 2>&1; then
cat "$output"
exit 1
fi
Expand Down
Loading