feat(domain discovery): add support for Domain Discovery commands #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FarhanSajid1
changed the title
Integralist
approved these changes
May 22, 2025
There was a problem hiding this comment.
This looks great! Thanks @FarhanSajid1
Just a couple of minor/nit comments and suggestions (approving to unblock).
cee-dub
reviewed
May 29, 2025
pkg/commands/domainv1/tools/root.go
Outdated
| func NewRootCommand(parent argparser.Registerer, g *global.Data) *RootCommand { | ||
| var c RootCommand | ||
| c.Globals = g | ||
| c.CmdClause = parent.Command(CommandName, "Tools for interacting with Domains") |
There was a problem hiding this comment.
This description seems to general/vague to me, and suggests that it might hold commands for managing domains.
There was a problem hiding this comment.
updated, let me know if that makes sense
Comment on lines
36
to
38
| // Optional. | ||
| cmd.RegisterFlagBool(cmd.JSONFlag()) | ||
| cmd.CmdClause.Flag("scope", "Scope determines the availability check to perform, specify `estimate` for an estimated check").Action(cmd.scope.Set).StringVar(&cmd.scope.Value) |
There was a problem hiding this comment.
@case-fastly should we expose this flag in the CLI? Not sure that's necessary.
Comment on lines
63
to
68
| WantOutput: `Domain Subdomain Zone Path | ||
| fastlytest.ing fastlytest. ing | ||
| fastlytesti.ng fastlytesti. ng | ||
| fastlytesting.com fastlytesting. com | ||
| fastlytesting.net fastlytesting. net | ||
| fastlytest.in fastlytest. in /g |
There was a problem hiding this comment.
@case-fastly is this output satisfactory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
This PR adds commands for
toolsand adomainsubcommand. Thetoolscommand will be used for placing tools moving forward.Once a user has enabled Domain Discovery on their accounts, they should have access to the Domain Discovery endpoints.
The commands make use of the
statusandsuggestimplementation which were added in fastly/go-fastly#672.The core changes:
domains, which will be a child oftools.suggestandstatussubcommands under toolssuggestandstatussubcommandsChanges to Core Features:
User Impact
Users that have enabled domain discovery on their accounts can use the
suggestandstatuscommands.Usage:
Fastly Tools
Fastly Domain Tools
Status Usage:
Status Commands
Suggest Usage:
Suggest Commands
Are there any considerations that need to be addressed for release?
No breaking changes