Skip to content

feat(domain discovery): add support for Domain Discovery commands #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

FarhanSajid1
Copy link

@FarhanSajid1 FarhanSajid1 commented May 21, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

This PR adds commands for the domain tools. Once a user has enabled Domain Discovery on their accounts, they should have access to the endpoints that enable this.

The commands make use of the status and suggest implementation which were added in fastly/go-fastly#672.

The core changes:

  • Add a root command for tools, which can be reused
  • Add suggest and status subcommands under tools
  • Tests for suggest and status subcommands

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Users that have enabled domain discovery on their accounts can use the suggest and status commands.

Are there any considerations that need to be addressed for release?

No breaking changes

@FarhanSajid1 FarhanSajid1 requested a review from Integralist May 21, 2025 16:13
@FarhanSajid1 FarhanSajid1 changed the title Farhansajid1/domain tools feat(domain discovery): add support for Domain Discovery commands May 21, 2025
@FarhanSajid1 FarhanSajid1 marked this pull request as ready for review May 21, 2025 18:48
@FarhanSajid1 FarhanSajid1 requested a review from a team as a code owner May 21, 2025 18:48
@FarhanSajid1 FarhanSajid1 requested a review from kpfleming May 21, 2025 18:48
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @FarhanSajid1

Just a couple of minor/nit comments and suggestions (approving to unblock).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants