-
-
Notifications
You must be signed in to change notification settings - Fork 73
feat: fastify-cli, vite, and typescript #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- small app and unit tests to test functionality
- testing with fastify-cli within itself fails, but outside of it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont use package-lock.json. So all your "updates" for semver minor updates are not relevant. But the semver major changes are.
package.json
Outdated
"jest": "^28.1.3", | ||
"@types/jest": "^29.5.12", | ||
"@types/node": "^20.11.24", | ||
"@types/tap": "^15.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we even have @types/tap? Can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it is used in typescript
testing in v16
.
https://github.com/fastify/fastify-autoload/blob/master/test/typescript/basic.ts#L1
Yes, it can be removed if we use v18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed new version.
@Uzlopak and @climba03003 I am 100% ok for your updating the packages file for no package lock. I just now that there is a combination or a single package causing this issue. I am just not sure which package makes my testing work.
But this is where I have problems. I not always sure what to do in this case. In all my apps, I keep the packages them up to date frequently for security and just keeping the code up to date. I understand that this is a plugin need to be more universal for a bigger mass. So whatever changes you think, I will accept and then test them with my code.
Please don't ties this to a fastify v5 release |
can you please add a test? |
Closing due to inactivity. |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct