Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql database support #475

Merged
merged 17 commits into from
Dec 25, 2024
Merged

Conversation

Meepoljdx
Copy link
Contributor

#353 做了PG的数据库支持,默认使用mysql,可以通过DB_TYPE指定数据库类型

image

@wu-clan
Copy link
Member

wu-clan commented Dec 12, 2024

一个令人十分激动的 PR,我会尽快 review

@Meepoljdx
Copy link
Contributor Author

一个令人十分激动的 PR,我会尽快 review

alembic直接迁移生成的迁移脚本在识别用with_variant实现数据库兼容的字段的时候会不准确,我一起提交了修正以后得migrate脚本文件,看看是否有必要,该文件我在mysql和pg都进行了测试

@wu-clan
Copy link
Member

wu-clan commented Dec 13, 2024

这会增加维护成本,我会调研一下这些配置带来的影响

@wu-clan
Copy link
Member

wu-clan commented Dec 24, 2024

alembic issue: sqlalchemy/alembic#1583

@wu-clan wu-clan changed the title feat: add postgresql db supports Add postgresql database support Dec 25, 2024
@wu-clan wu-clan self-requested a review December 25, 2024 13:59
@wu-clan wu-clan merged commit 78dad30 into fastapi-practices:master Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants