reorganized +polytens (sorry manas) #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrachh
reviewed
Oct 28, 2025
There was a problem hiding this comment.
A minor suggestion: maybe we should call the function interpolate_data or interpolate_fun instead?
More substantively, it should work for a vector of densities which can be of size (npts, nfun) or (nfun, npts). See src/vals_to_coefs_surface_fun for an example. Finally might help to bracket c2v*(v2c*vals) just to make sure it doesn't hurt us in the long run.
And once I pull in your changes I will be deleting vals_to_coefs_surface_fun as it does the same thing as surfer/vals2coefs, although I like the former code.
Looks great otherwise, thanks Peter!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved and renamed polytens.cheb_NAME to polytens.cheb.NAME and made the corresponding changes to polytens.lege_NAME. also changed plot.m, surfer.m, oversample.m, and vals2coefs.m in @Surfer as well as a few of the tests to reflect these changes in syntax.