feat: background uploads #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidentical
force-pushed
the
background-uploads
branch
from
771912d to
51e8c3b
Compare
chamini2
approved these changes
Jan 29, 2024
Comment on lines
+95
to
+96
| if future in self.uploads: | ||
| self.uploads.remove(future) |
There was a problem hiding this comment.
ATL: why the if? if it's for race conditions, shouldn't we do a better locking mechanism or handle KeyError exception?
isidentical
force-pushed
the
background-uploads
branch
from
51e8c3b to
19ba9e3
Compare
|
actually this is not ideal in the current form because if you return a url that isn't uploaded yet, the UI will fail to render it in the fal's REST storage service (unlike the CDN, which actually blocks the user until the file is ready). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a big fan of doing this opt-in (since it is an obscure feature) but currently we don't have a way of running finalizations in fal, which means you can't use this with SDK for example (because this will still be uploading stuff even after the execution is complete in which case our scheduler will terminate thinking there is nothing left). This is an advanced thing we can only enable for our production APIs at the moment.