Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolkit): introduce fal_v3 repository #317

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat(toolkit): introduce fal_v3 repository #317

merged 3 commits into from
Sep 30, 2024

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Sep 30, 2024

Straight-up v1 code copied and adapted to support v3 auth.

This allows us to start testing v3 out.

Multipart will be introduced separately.

We also change default lifecycle policy here to never expire, as that seemed to be the conclusion of our recent conversation about it. Note that we still set it for v1 too, but v1 is ignoring those.

@efiop efiop changed the title feat(toolkit): introduce fal_v3 repository [WIP] feat(toolkit): introduce fal_v3 repository Sep 30, 2024
@efiop efiop marked this pull request as draft September 30, 2024 13:29
@efiop efiop changed the title [WIP] feat(toolkit): introduce fal_v3 repository feat(toolkit): introduce fal_v3 repository Sep 30, 2024
@efiop efiop requested a review from chamini2 September 30, 2024 13:54
@efiop efiop marked this pull request as ready for review September 30, 2024 13:54
@efiop efiop requested a review from chamini2 September 30, 2024 18:23
Copy link
Member

@chamini2 chamini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@efiop efiop merged commit f57dc0c into main Sep 30, 2024
4 of 6 checks passed
@efiop efiop deleted the ruslan/cdn-v3 branch September 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants