Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: add machine_types and num_gpus option #288

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

chamini2
Copy link
Member

@chamini2 chamini2 commented Aug 26, 2024

closes FEA-3123

@chamini2 chamini2 requested a review from efiop August 26, 2024 16:57
Copy link

linear bot commented Aug 26, 2024

@chamini2 chamini2 force-pushed the matteo/machine-types branch from 3242c64 to e9288f6 Compare August 26, 2024 21:55
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about grpcio version

@chamini2 chamini2 force-pushed the matteo/machine-types branch from e9288f6 to 9171d92 Compare August 29, 2024 02:02
@chamini2 chamini2 changed the title proto: add machine_types option proto: add machine_types and num_gpus option Aug 29, 2024
@chamini2 chamini2 requested a review from efiop August 29, 2024 15:14
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when ready.

@chamini2 chamini2 merged commit bce6eb3 into main Aug 29, 2024
5 of 6 checks passed
@chamini2 chamini2 deleted the matteo/machine-types branch August 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants