Skip to content

Improve scripts when used in a loop #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fetch_repos.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def get_repo_list(user):

return repo_list

print("Unable to fetch repositories")
print("Unable to fetch repositories for", user)
return None


Expand Down
18 changes: 10 additions & 8 deletions generate_markdown.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@
GitHub.

Usage:
generate_markdown.py <user> [-o <type>] [-r]
generate_markdown.py <user> -o table [-c <cols>] [-r]
generate_markdown.py <user> [-o <type>] [-r] [-a]
generate_markdown.py <user> -o table [-c <cols>] [-r] [-a]
generate_markdown.py -h

Options:
-o <type>, --output-as <type> Generate Markdown for either a list or a table
[default: list].
-c <cols>, --columns <cols> Number of columns for the table [default: 3].
-a, --append Append to file.
-r, --reverse-order Generate output in reverse chronological
order.
-h, --help Display this help text.
Expand All @@ -35,8 +36,8 @@
'''


def output_list(user, repo_list, output_file):
with open(output_file, "w") as file:
def output_list(user, repo_list, output_file, mode):
with open(output_file, mode) as file:
for repo in repo_list:
owner, repo_name = repo.split("/")
file.write(LIST_ITEM.format(user=user, repo=repo, owner=owner,
Expand All @@ -45,8 +46,8 @@ def output_list(user, repo_list, output_file):
.format(output_file))


def output_table(user, repo_list, num_columns, output_file):
with open(output_file, "w") as file:
def output_table(user, repo_list, num_columns, output_file, mode):
with open(output_file, mode) as file:
file.write("<table>\n<tr>\n")
repos_written = 0
for repo in repo_list:
Expand All @@ -64,6 +65,7 @@ def output_table(user, repo_list, num_columns, output_file):
if __name__ == '__main__':
arguments = docopt(__doc__)

mode = "a" if arguments['--append'] else "w"
user = arguments['<user>']
repo_list = get_repo_list(user)
if repo_list:
Expand All @@ -76,10 +78,10 @@ def output_table(user, repo_list, num_columns, output_file):
output_file = os.path.join(output_dir, "contribution-" + output_as +
".md")
if output_as == 'list':
output_list(user, repo_list, output_file)
output_list(user, repo_list, output_file, mode)
elif output_as == 'table':
num_columns = int(arguments['--columns'])
output_table(user, repo_list, num_columns, output_file)
output_table(user, repo_list, num_columns, output_file, mode)
else:
print("Invalid value for output type! Possible values: 'list', "
"'table'")