-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow Makefile default settings to be overridden by environment variables; patch contributed by Ionic
- Loading branch information
Showing
2 changed files
with
28 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a62dd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @faf0 .
Add attach:
do not work.
sct-1.8.1.tar.xz
in https://github.com/faf0/sct/releases/tag/1.8.1Without this, statistics
2a62dd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this to my attention, @zvezdochiot .
I ended up removing the downloads button, as there are no releases at the moment: 1bfe075
2a62dd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @faf0 .
It was easier to add
sct-1.8.1.tar.xz
to the current release.2a62dd4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that adding
sct-1.8.1.tar.xz
is easy. However, the download statistics won't reflect who just clones the repo and builds sct, which I think is the preferred workflow, unless the distribution comes with a packaged version already. Not sure ifsct-1.8.1.tar.xz
provides much value and it can get inconsistent with the actual code easily. To avoid this, a GitHub Actions workflow can create this file whenever a new release tag is added, but then again I think it's just easier to build the sct binary from the repo rather than the.tar.xz
.