chore: Apply code style fixes for php 8.4

src/Command/BaseCommand.php

@@ -205,7 +205,7 @@ public function runCommand(
         array $args,
         InputInterface $original_input,
         OutputInterface $output,
-        TaskContextInterface $context_to_pass = null
+        ?TaskContextInterface $context_to_pass = null
     ) {
         $cmd = $this->getApplication()->find($command);
 
@@ -257,7 +257,7 @@ protected function startInteractiveShell(
         TaskContextInterface $context,
         ShellProviderInterface $shell,
         array $command = [],
-        ShellOptions $options = null
+        ?ShellOptions $options = null
     ) {
         $fn = function ($type, $buffer) use ($context) {
             if ($type == Process::ERR) {

src/Command/StartRemoteAccessCommand.php

@@ -9,7 +9,8 @@
 class StartRemoteAccessCommand extends BaseCommand
 {
 
-    protected function configure(): void {
+    protected function configure(): void
+    {
         $host= gethostname();
         $ip = false;
 
@@ -104,7 +105,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return $this->getContext()->getResult('exitCode', 0);
     }
 
-    private function getSchemeFromPort($port): string {
+    private function getSchemeFromPort($port): string
+    {
         $mapping = [
             '80' => 'http',
             '443' => 'https',

src/Method/Callbacks/WebHookCallback.php

@@ -24,7 +24,7 @@ public static function requires(): string
         return "3.6";
     }
 
-    public function __construct(WebhookMethod $method = null)
+    public function __construct(?WebhookMethod $method = null)
     {
         $this->method = $method;
     }

src/Scaffolder/Scaffolder.php

@@ -86,7 +86,7 @@ public function scaffold(
         $root_folder,
         TaskContextInterface $in_context,
         array $tokens = [],
-        Options $options = null
+        ?Options $options = null
     ) {
         if (!$options) {
             $options = new Options();

src/ShellProvider/DryRunShellProvider.php

@@ -96,7 +96,7 @@ public function getShellCommand(array $program_to_call, ShellOptions $options):
         throw new \RuntimeException("getShellCommand not implemented!");
     }
 
-    public function createShellProcess(array $command = [], ShellOptions $options = null): Process
+    public function createShellProcess(array $command = [], ?ShellOptions $options = null): Process
     {
         throw new \RuntimeException("createShellProcess not implemented!");
     }

src/ShellProvider/KubectlShellProvider.php

@@ -75,7 +75,7 @@ public function validateConfig(Node $config, ValidationErrorBagInterface $errors
         }
     }
 
-    public function createShellProcess(array $command = [], ShellOptions $options = null): Process
+    public function createShellProcess(array $command = [], ?ShellOptions $options = null): Process
     {
         // Apply kubectl environment vars.
         $this->setShellEnvironmentVars($this->hostConfig['kube']['environment']);

src/ShellProvider/LocalShellProvider.php

@@ -82,7 +82,7 @@ public function validateConfig(Node $config, ValidationErrorBagInterface $errors
         );
     }
 
-    public function createShellProcess(array $command = [], ShellOptions $options = null): Process
+    public function createShellProcess(array $command = [], ?ShellOptions $options = null): Process
     {
         if (!$options) {
             $options = new ShellOptions();

src/ShellProvider/RunOptions.php

@@ -2,18 +2,20 @@
 
 namespace Phabalicious\ShellProvider;
 
-enum RunOptions {
+enum RunOptions
+{
     case NONE;
     case CAPTURE_OUTPUT;
     case HIDE_OUTPUT;
     case CAPTURE_AND_HIDE_OUTPUT;
 
-    public function isCapturingOutput(): bool {
+    public function isCapturingOutput(): bool
+    {
         return $this === self::CAPTURE_OUTPUT || $this === self::CAPTURE_AND_HIDE_OUTPUT;
     }
 
-    public function hideOutput(): bool {
+    public function hideOutput(): bool
+    {
         return $this === self::HIDE_OUTPUT || $this === self::CAPTURE_AND_HIDE_OUTPUT;
     }
-
 }

src/ShellProvider/ShellOptions.php

@@ -45,7 +45,8 @@ public function setQuiet(bool $quiet): ShellOptions
         return $this;
     }
 
-    public function isShellExecutableProvided(): bool {
+    public function isShellExecutableProvided(): bool
+    {
         return $this->shellExecutableProvided;
     }
 

src/ShellProvider/ShellProviderInterface.php

@@ -68,7 +68,7 @@ public function runProcess(array $cmd, TaskContextInterface $context, $interacti
 
     public function getShellCommand(array $program_to_call, ShellOptions $options): array;
 
-    public function createShellProcess(array $command = [], ShellOptions $options = null): Process;
+    public function createShellProcess(array $command = [], ?ShellOptions $options = null): Process;
 
     public function createTunnelProcess(HostConfig $target_config, array $prefix = []): Process;
 

src/ShellProvider/SubShellProvider.php

@@ -70,7 +70,7 @@ public function getShellCommand(array $program_to_call, ShellOptions $options):
         throw new \LogicException("getShellCommand not implemented");
     }
 
-    public function createShellProcess(array $command = [], ShellOptions $options = null): Process
+    public function createShellProcess(array $command = [], ?ShellOptions $options = null): Process
     {
         throw new \LogicException("createShellProcess not implemented");
     }
@@ -85,7 +85,8 @@ public function wrapCommandInLoginShell(array $command): array
         throw new \LogicException("wrapCommandInLoginShell not implemented");
     }
 
-    public function terminate(): void {
+    public function terminate(): void
+    {
         $this->parentShell->terminate();
     }
 

src/ShellProvider/TunnelHelper/HostToHostTunnelInterface.php

@@ -12,6 +12,6 @@ public function createHostToHostTunnel(
         HostConfig $source_config,
         HostConfig $dest_config,
         TaskContextInterface $context,
-        TunnelDataInterface $tunnel_data = null
+        ?TunnelDataInterface $tunnel_data = null
     ): TunnelDataInterface;
 }

src/ShellProvider/TunnelHelper/LocalToHostTunnelInterface.php

@@ -11,6 +11,6 @@ interface LocalToHostTunnelInterface
     public function createLocalToHostTunnel(
         HostConfig $config,
         TaskContextInterface $context,
-        TunnelDataInterface $tunnel_data = null
+        ?TunnelDataInterface $tunnel_data = null
     ): TunnelDataInterface;
 }

src/ShellProvider/TunnelHelper/SshTunnelHelper.php

@@ -14,7 +14,7 @@ class SshTunnelHelper extends TunnelHelperBase implements HostToHostTunnelInterf
     public function createLocalToHostTunnel(
         HostConfig $config,
         TaskContextInterface $context,
-        TunnelDataInterface $tunnel_data = null
+        ?TunnelDataInterface $tunnel_data = null
     ): TunnelDataInterface {
         return $this->createTunnel($config, $config, false, $context, $tunnel_data);
     }
@@ -23,7 +23,7 @@ public function createHostToHostTunnel(
         HostConfig $source_config,
         HostConfig $target_config,
         TaskContextInterface $context,
-        TunnelDataInterface $tunnel_data = null
+        ?TunnelDataInterface $tunnel_data = null
     ): TunnelDataInterface {
         return $this->createTunnel($source_config, $target_config, true, $context, $tunnel_data);
     }
@@ -43,7 +43,7 @@ private function createTunnel(
         HostConfig $target_config,
         bool $remote,
         TaskContextInterface $context,
-        TunnelDataInterface $tunnel_data = null
+        ?TunnelDataInterface $tunnel_data = null
     ) {
         $key = $source_config->getConfigName() . '->' . $target_config->getConfigName();
         if ($remote) {

src/Utilities/EnsureKnownHosts.php

@@ -22,7 +22,7 @@ final class EnsureKnownHosts
     public static function ensureKnownHosts(
         ConfigurationService $config,
         array $known_hosts,
-        ShellProviderInterface $shell = null
+        ?ShellProviderInterface $shell = null
     ) {
         if (!$shell) {
             $shell = ShellProviderFactory::create('local', $config->getLogger());

src/Utilities/ParallelExecutorRun.php

@@ -19,7 +19,7 @@ class ParallelExecutorRun extends ProcessRun
 
     protected $identifier;
 
-    public function __construct(string $identifier, $command_line, ConsoleSectionOutput $output = null)
+    public function __construct(string $identifier, $command_line, ?ConsoleSectionOutput $output = null)
     {
         $this->identifier = $identifier;
         $this->output = $output;