Skip to content

Make static properties/methods accessible through the runtime object built from the class #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MeesterDev
Copy link

This solves #125.

I initially considered throwing an error where there is now a warning, but settled on a warning to prevent breaking existing code.
image

continue;
}
if ((property in target) && !(property in previouslyAssigned)) {
console.warn(`Property/method ${property} of ${classObject.name} is not supported for static access, as it conflicts with names on the underlying Vue object.`);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.warn(`Property/method ${property} of ${classObject.name} is not supported for static access, as it conflicts with names on the underlying Vue object.`);
console.warn(`Property/method ${property} of ${classObject.name} is not supported for static access, as it conflicts with names in the underlying Vue object.`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant