Fix errors when accessing document global on server #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also fix #296 |
| @@ -330,6 +330,7 @@ class ExtractCssChunksPlugin { | |||
| '', | |||
| `// ${pluginName} CSS loading`, | |||
| `var supportsPreload = ${supportsPreload}`, | |||
| `if (typeof document === "undefined") { return; }`, | |||
There was a problem hiding this comment.
this could even happen at the very beginning to prevent the supportsPreload function execution
netconomy-stephan-dum
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the plugin in a server-side rendering context there is no document global where script or link tags could be added to. In this case typically all scripts and link tags are collected and added by the renderer itself so nothing needs to be executed by the plugin on require.
This patch detects the existence of the document global and skips adding nodes if it doesn't exist. Also fixed test cases. Feedback welcome, maybe there is a better way to do this?