Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many fixes and improvements to unrestrict the Meta SAM2 demo viz #610

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dav-ell
Copy link

@dav-ell dav-ell commented Mar 20, 2025

  • ✅ Fix docker-compose build issues
  • ✅ Fix PyAV missing side_data issue preventing custom video uploads by extracting rotation information manually
  • ✅ Add support for running this interface and backend on a remote machine (see updated docker-compose.yaml for example environemnt variable setting)
  • ✅ Remove limit of 3 objects from the UI.
  • ️✅ Add support for up to 15 object mask colors (limited by WebGL)
  • ️✅ Add download_masks graphql endpoint to the server
  • ✅ Improve server-side logging to terminal to display session ID
  • ️✅ Include download_masks.py utility script, and masks_to_boxes.py and viz_boxes.py for those interested in bounding boxes

…ation

- ✅ Fix docker-compose build issues
- ✅ Fix PyAV missing side_data issue preventing custom video uploads by extracting rotation information manually
- ✅ Add support for running this interface and backend on a remote machine (see updated docker-compose.yaml for example environemnt variable setting)
- ✅ Remove limit of 3 objects from the UI.
- ️✅ Add support for up to 15 object mask colors (limited by WebGL)
- ️✅ Add `download_masks` graphql endpoint to the server
- ✅ Improve server-side logging to terminal to display session ID
- ️✅ Include [download_masks.py](demo/backend/download_masks.py) utility script, and [masks_to_boxes.py](demo/backend/masks_to_boxes.py) and [viz_boxes.py](demo/backend/viz_boxes.py) for those interested in bounding boxes
@facebook-github-bot
Copy link

Hi @dav-ell!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants