Skip to content

[tests] Automate Jupyter notebook tests using nbmake. #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

ChrisCummins
Copy link
Contributor

This uses the nbmake pytest plugin to run the Jupyter notebooks in
make examples-test.

Fixes #450.

@ChrisCummins ChrisCummins added this to the v0.2.1 milestone Oct 6, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2021
@alex-treebeard
Copy link

hey @ChrisCummins , I just released nbmake==0.10 which should work with pytest 6.1.0. Bugs/requests welcome!

@ChrisCummins
Copy link
Contributor Author

hey @ChrisCummins , I just released nbmake==0.10 which should work with pytest 6.1.0. Bugs/requests welcome!

Thanks for the heads up @alex-treebeard!

Cheers,
Chris

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #454 (3a6755a) into development (283941e) will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #454      +/-   ##
===============================================
- Coverage        87.33%   86.99%   -0.35%     
===============================================
  Files              113      113              
  Lines             6403     6403              
===============================================
- Hits              5592     5570      -22     
- Misses             811      833      +22     
Impacted Files Coverage Δ
compiler_gym/util/logging.py 0.00% <0.00%> (-100.00%) ⬇️
compiler_gym/util/flags/seed.py 0.00% <0.00%> (-100.00%) ⬇️
compiler_gym/util/flags/episodes.py 0.00% <0.00%> (-100.00%) ⬇️
compiler_gym/util/flags/output_dir.py 0.00% <0.00%> (-100.00%) ⬇️
compiler_gym/util/flags/learning_rate.py 0.00% <0.00%> (-100.00%) ⬇️
compiler_gym/util/flags/episode_length.py 0.00% <0.00%> (-100.00%) ⬇️
compiler_gym/util/flags/benchmark_from_flags.py 66.66% <0.00%> (-13.34%) ⬇️
compiler_gym/spaces/commandline.py 85.71% <0.00%> (-3.58%) ⬇️
compiler_gym/util/flags/env_from_flags.py 87.50% <0.00%> (-2.09%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 88.59% <0.00%> (+2.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283941e...3a6755a. Read the comment docs.

* Bump ray dependency 1.8 -> 1.9 after having problems installing 1.8.

* Don't specify numpy version (facebookresearch#501).
This uses the nbmake pytest plugin to run the Jupyter notebooks in
`make examples-test`.

Fixes facebookresearch#450.
@facebook-github-bot
Copy link

Hi @ChrisCummins!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate testing of example Jupyter notebooks
4 participants