-
Notifications
You must be signed in to change notification settings - Fork 132
[tests] Automate Jupyter notebook tests using nbmake. #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
[tests] Automate Jupyter notebook tests using nbmake. #454
Conversation
hey @ChrisCummins , I just released nbmake==0.10 which should work with pytest 6.1.0. Bugs/requests welcome! |
Thanks for the heads up @alex-treebeard! Cheers, |
d3148c2
to
e4a94f5
Compare
Codecov Report
@@ Coverage Diff @@
## development #454 +/- ##
===============================================
- Coverage 87.33% 86.99% -0.35%
===============================================
Files 113 113
Lines 6403 6403
===============================================
- Hits 5592 5570 -22
- Misses 811 833 +22
Continue to review full report at Codecov.
|
6b680ca
to
750b733
Compare
060f8ac
to
7594a71
Compare
750b733
to
807dce9
Compare
807dce9
to
f273507
Compare
f273507
to
a9c62da
Compare
* Bump ray dependency 1.8 -> 1.9 after having problems installing 1.8. * Don't specify numpy version (facebookresearch#501).
This uses the nbmake pytest plugin to run the Jupyter notebooks in `make examples-test`. Fixes facebookresearch#450.
a9c62da
to
3a6755a
Compare
Hi @ChrisCummins! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This uses the nbmake pytest plugin to run the Jupyter notebooks in
make examples-test
.Fixes #450.