github: rework Docker build, and publish new images #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for fb-oss-glean canceled.
|
simonmar
approved these changes
Jan 24, 2025
| @@ -132,9 +132,18 @@ cxx-libraries: | |||
| cxx-test-%: force | |||
| @$(MAKE) -f mk/cxx.mk --no-print-directory CXX_MODE=$(CXX_MODE) CXX_DIR=$(CXX_DIR) $@ | |||
|
|
|||
| GLEAN_CABAL_BINS=glean glean-server glean-hyperlink | |||
| GLEAN_NATIVE_LIBS=librocksdb.so.8 libfolly.so.0.58.0-dev libfmt.so.11 | |||
There was a problem hiding this comment.
this looks fragile, can we make it independent of the version numbers?
There was a problem hiding this comment.
Maybe we can just do librocksdb.so.* or something like that and let bash do the rest of the magic for us
|
Note that this still needs to actually push the images to the Docker registry, so it's not quite ready yet. |
thoughtpolice
force-pushed
the
aseipp/push-zsqoxtmnunrl
branch
3 times, most recently
from
b2dc3a0 to
31bf67a
Compare
This reworks the `Dockerfile` to now build multiple images, including one for end users to run their own copy of Glean, and an updated version of the React demo database. It includes x86_64 and aarch64 Linux images using public GHA runners, which probably covers 98% of all realistic uses. (Using GHA runners means this workflow is trivially usable for public forks, too.) There is a new `bindist` target used by the Dockerfile that creates a directory of needed binaries and libraries, and properly packages them for usage in the container. There are now three containers published from the `Dockerfile`, all based on Ubuntu 24.04: - `glean/client`, which only contains the `glean` command, then - `glean/server`, including `glean-server`, then - `glean/demo`, including a precanned `glean-hyperlink` + react DB These containers are all size-optimized; the final images have no development tools installed and the absolute minimum necessary installed packages. For example, the new x86_64 `glean/demo` is only 486MB uncompressed, compared to the 2.4GB of the previous demo version. The `client` and `server` images are 251MB and 300MB, respectively. The `client` image should probably include `gen-schema` so that end users can generate code from their own non-upstream `.angle` files, but that can be added in a future patch. In theory, this new container could also be used to replace most of the junk in `ci.yml` in order to repeat ourselves less, but it would need another image in order to add more things so that the test suite can be run. That can happen in a future patch. Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-zsqoxtmnunrl
branch
from
31bf67a to
925fd19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the
Dockerfileto now build multiple images, including one for end users to run their own copy of Glean, and an updated version of the React demo database. It includes x86_64 and aarch64 Linux images using public GHA runners, which probably covers 98% of all realistic uses. (Using GHA runners means this workflow is trivially usable for public forks, too.)There is a new
bindisttarget used by the Dockerfile that creates a directory of needed binaries and libraries, and properly packages them for usage in the container.There are now three containers published from the
Dockerfile, all based on Ubuntu 24.04:glean/client, which only contains thegleancommand, thenglean/server, includingglean-server, thenglean/demo, including a precannedglean-hyperlink+ react DBThese containers are all size-optimized; the final images have no development tools installed and the absolute minimum necessary installed packages. For example, the new x86_64
glean/demois only 486MB uncompressed, compared to the 2.4GB of the previous demo version. Theclientandserverimages are 251MB and 300MB, respectively.The
clientimage should probably includegen-schemaso that end users can generate code from their own non-upstream.anglefiles, but that can be added in a future patch.In theory, this new container could also be used to replace most of the junk in
ci.ymlin order to repeat ourselves less, but it would need another image in order to add more things so that the test suite can be run. That can happen in a future patch.