Skip to content

decompress: return the skippable header size from ZSTD_frameHeaderSize() - #4834

Open
ilyas-mallah wants to merge 1 commit into
facebook:devfrom
ilyas-mallah:frame-header-size-skippable
Open

ilyas-mallah wants to merge 1 commit into
facebook:devfrom
ilyas-mallah:frame-header-size-skippable

Conversation

@ilyas-mallah

Copy link
Copy Markdown

What and why

For a skippable frame, ZSTD_getFrameHeader() reports a header size of 8, as the format spec says: a 4-byte Magic_Number and a 4-byte Frame_Size. ZSTD_frameHeaderSize() doesn't check the magic number. It reads the low byte of Frame_Size as a Frame_Header_Descriptor and returns whatever header size that byte would describe, anything from 6 to 18. A skippable frame with 5 bytes of content gives 7.

Internal callers only use the internal version for zstd frames, so only the public function's result changes. The new test sits with the other skippable frame tests in tests/fuzzer.c, fails on dev and passes with this change, and make -C tests test-fuzzer passes.

Checklist

  • I searched open pull requests and issues: this problem is not already being addressed.
  • Bug fix: it comes with a reproducer or a test that fails without the fix.
  • Performance change: numbers from repeated runs are included, with CPU, compiler, flags and data.
  • I stated below whether AI or other automated tools were used.

Tools used

AI usage: Claude Code helped with the test runs. I traced the mismatch, made the fix, and validated every change.

@meta-cla

meta-cla Bot commented Oct 9, 2026

Copy link
Copy Markdown

Hi @ilyas-mallah!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Oct 9, 2026
@meta-cla

meta-cla Bot commented Oct 9, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ceedot-rock

Copy link
Copy Markdown

@Cyan4973 — small API correctness fix: ZSTD_frameHeaderSize() now returns the skippable header size for skippable frames. Clean 10-line change. Anything blocking?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants