Skip to content

[meson] fix: Unresolved symbols when linking some programs on old glibc #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roshandhiman wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[meson] fix: Unresolved symbols when linking some programs on old glibc #4829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/meson/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ feature_lz4 = get_option('lz4')
# =============================================================================

libm_dep = cc.find_library('m', required: false)
# Needed for `clock_gettime` before glibc 2.17.
rt_dep = cc.find_library('rt', required: false)
if host_machine_os == os_windows
thread_dep = dependency('', required: false)
use_multi_thread = not feature_multi_thread.disabled()
Expand Down
4 changes: 2 additions & 2 deletions build/meson/programs/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ zstd_programs_sources = [join_paths(zstd_rootdir, 'programs/zstdcli.c'),
join_paths(zstd_rootdir, 'programs/dibio.c'),
join_paths(zstd_rootdir, 'programs/zstdcli_trace.c')]

zstd_deps = [ libzstd_internal_dep ]
zstd_deps = [ libzstd_internal_dep, rt_dep ]
zstd_c_args = libzstd_debug_cflags

zstd_frugal_deps = [ libzstd_internal_dep ]
zstd_frugal_deps = [ libzstd_internal_dep, rt_dep ]
zstd_frugal_c_args = [ '-DZSTD_NOBENCH', '-DZSTD_NODICT', '-DZSTD_NOTRACE' ]

if use_multi_thread
Expand Down
2 changes: 1 addition & 1 deletion build/meson/tests/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ testcommon = static_library('testcommon',
link_with: libzstd_static)

testcommon_dep = declare_dependency(link_with: testcommon,
dependencies: libzstd_deps,
dependencies: [ libzstd_deps, rt_dep ],
include_directories: libzstd_includes)

datagen_sources = [join_paths(zstd_rootdir, 'tests/datagencli.c'),
Expand Down