Repository navigation
ci: use the VS 2026 generator for the MSVC ARM64 job - #4824
Merged
Merged
Conversation
The windows-11-arm runner label now resolves to the windows-11-vs2026-arm64 image (20260924), which ships Visual Studio 2026 and CMake 4.4, but no longer Visual Studio 2022. CMake fails at configure time with "could not find any instance of Visual Studio", so the job fails on every PR opened since 2026-10-01 (e.g. #4806, #4811, #4813). Switch that matrix entry to the "Visual Studio 18 2026" generator. The x64 and Win32 entries run on windows-2022 and are unaffected. Drop "VS2022" from the job name template, which would now be wrong for the ARM64 entry: jobs become "CMake Windows (<entry>)". No branch protection rule requires these checks by name.
Cyan4973
added a commit
that referenced
this pull request
Oct 5, 2026
intel-cet-compatibility runs ./zstd under SDE without a chip option, so SDE checks instructions against the host's cpuid. On runners whose CPU lacks CET, it aborts at the first endbr64, in the dynamic loader, before zstd runs: SDE-ERROR: Executed instruction not valid for host's cpuid: endbr64 Notice: No chip or cpuid.def file were given, so host's cpuid was used for chip check. The job thus passes or fails depending on the runner it lands on: it failed on #4824 (Azure westus3) and passed 15 minutes earlier on #4823 (westus2), on the same workflow. Pass -tgl, the first Intel chip with CET, so the check no longer depends on the host. Verified locally with SDE 10.13.1 on an AMD EPYC host (no CET): without -tgl, the CI failure reproduces; with -tgl, zstd -b3 passes, and a CET-marked test binary with an indirect call to a function lacking endbr64 is still caught (ENDBRANCH error, exit 1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-11-arm runner label now resolves to the windows-11-vs2026-arm64 image (20260924), which ships Visual Studio 2026 and CMake 4.4.
Switch that matrix entry to the "Visual Studio 18 2026" generator. The x64 and Win32 entries run on windows-2022 and are unaffected.