Repository navigation
Update contribution rules - #4823
Merged
Merged
Conversation
Add a pull request template with a short checklist: existing PRs and issues searched, a reproducer or test for bug fixes, benchmark numbers for performance changes, and whether AI or other tools were used. In CONTRIBUTING.md: - list the same expectations, plus one fix per PR and no public PR for security bugs; - state the review bar per directory: lib/ and programs/ get a full review, contrib/ has more freedom, legacy decoders only take memory-safety and regression fixes with a test; - performance: x86-64 and AArch64 are benchmarked by maintainers; other architectures need small, #ifdef-isolated changes with the contributor's own numbers. Ask contributors to state precisely what they measured: a gain in one configuration is not a general gain.
Add an issue template config.yml with a contact link to SECURITY.md, so security bugs are steered away from public issues before one is opened.
Cyan4973
force-pushed
the
contrib-rules
branch
from
October 5, 2026 23:16
534d119 to
1c59737
Compare
Cyan4973
added a commit
that referenced
this pull request
Oct 5, 2026
intel-cet-compatibility runs ./zstd under SDE without a chip option, so SDE checks instructions against the host's cpuid. On runners whose CPU lacks CET, it aborts at the first endbr64, in the dynamic loader, before zstd runs: SDE-ERROR: Executed instruction not valid for host's cpuid: endbr64 Notice: No chip or cpuid.def file were given, so host's cpuid was used for chip check. The job thus passes or fails depending on the runner it lands on: it failed on #4824 (Azure westus3) and passed 15 minutes earlier on #4823 (westus2), on the same workflow. Pass -tgl, the first Intel chip with CET, so the check no longer depends on the host. Verified locally with SDE 10.13.1 on an AMD EPYC host (no CET): without -tgl, the CI failure reproduces; with -tgl, zstd -b3 passes, and a CET-marked test binary with an indirect call to a function lacking endbr64 is still caught (ENDBRANCH error, exit 1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the age of AI, the project need more guardrails, to mitigate the influx of AI-generated issues and PRs