Repository navigation
test: cover CMake subdirectory consumers - #4822
Open
Hrushikesh-ramilla wants to merge 1 commit into
Open
Hrushikesh-ramilla wants to merge 1 commit into
Hrushikesh-ramilla wants to merge 1 commit into
Conversation
Hrushikesh-ramilla
force-pushed
the
test/cmake-subdirectory-consumers
branch
from
October 9, 2026 21:33
c9e787b to
89c0ac5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the CMake consumer regression coverage requested in #3758. The target header interfaces are already present; this change protects them with a separate parent project that links
libzstd_staticandlibzstd_sharedwithout manually supplying include paths.Both C++98 consumers include
zstd.h,zstd_errors.h, andzdict.h, compress and decompress a buffer, and verify the round trip. The existing Linux, macOS, and Windows paths-with-spaces jobs configure, build, and run the consumers. On Windows, the shared consumer receives its DLL next to the executable.A separate CI repair commit fixes two setup failures encountered during fork validation:
platform-toolsexplicitly from the pinned Android setup action, avoiding the removedtoolspackage. The existing NDK installation and builds remain in place.Relates to #3758 and #2377.
Validation
zstd.h; restoring the interfaces makes both pass again./analyzepasses for both consumer programs.git diff --checkpass.c9e787b: all 104 check jobs pass across all five workflows (commit, short tests, long tests, CMake, and Android NDK).AI assistance: Codex assisted with the regression fixture, workflow changes, and validation.