Skip to content

Update CMakeLists.txt#4704

Open
lhmouse wants to merge 1 commit into
facebook:devfrom
lhmouse:patch-1
Open

Update CMakeLists.txt#4704
lhmouse wants to merge 1 commit into
facebook:devfrom
lhmouse:patch-1

Conversation

@lhmouse

@lhmouse lhmouse commented Jul 2, 2026

Copy link
Copy Markdown

pthread has been checked in build/cmake/CMakeLists.txt; there's no need to check it again.

On Windows, zstd can be built without winpthreads. It may check for existence of a pthread library, but nothing is linked from it. However, this causes errors when no pthread library is available.

Either way, this check isn't meaningful.

pthread has been checked in build/cmake/CMakeLists.txt; there's no need to
check it again.

On Windows, zstd can be built without winpthreads. It may check for existence
of a pthread library, but nothing is linked from it. However, this causes
errors when no pthread library is available.

Either way, this check isn't meaningful.
Copilot AI review requested due to automatic review settings July 2, 2026 09:37
@meta-cla

meta-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Hi @lhmouse!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CMake build for the pzstd contrib target to stop hard-failing when CMake detects a non-pthreads threading implementation (notably on Windows), aligning with the project’s ability to build on Windows without linking a pthread library.

Changes:

  • Remove the CMAKE_USE_PTHREADS_INIT gating and associated SEND_ERROR for pzstd.
  • Always link pzstd against ${CMAKE_THREAD_LIBS_INIT} (which may be empty on platforms where no extra thread lib is needed).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meta-cla meta-cla Bot added the CLA Signed label Jul 2, 2026
@meta-cla

meta-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants