Fix failing GitHub workflows#38
Closed
kvelakur wants to merge 1 commit into
Closed
Conversation
|
@kvelakur has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110124796. |
Summary: Pull Request: #38 # Fix linux-sdk packaging and macOS wheel CI failures Two CMake fixes: - **deb/rpm packaging**: add a `PACKAGING_TEST` option and `test_solve` target so `build_linux_sdk.sh` (passing `-DPACKAGING_TEST=ON`) builds and installs the smoke-test binary to `bin/`. - **macOS wheels**: set `INSTALL_RPATH_USE_LINK_PATH` plus `loader_path/_lib` on the SKBUILD targets so `delocate` can resolve and bundle `librebalancer.dylib` and the getdeps deps (libfolly, ...). Without baked-in rpaths it failed with `DelocationError: Could not find all dependencies`. Differential Revision: D110124796
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D110124796
branch
from
0e4b62c to
c7b43ef
Compare
|
This pull request has been merged in 645eee3. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request: #38
Fix linux-sdk packaging and macOS wheel CI failures
Two CMake fixes:
PACKAGING_TESToption andtest_solvetarget sobuild_linux_sdk.sh(passing-DPACKAGING_TEST=ON) builds and installs the smoke-test binary tobin/.INSTALL_RPATH_USE_LINK_PATHplusloader_path/_libon the SKBUILD targets sodelocatecan resolve and bundlelibrebalancer.dyliband the getdeps deps (libfolly, ...). Without baked-in rpaths it failed withDelocationError: Could not find all dependencies.Differential Revision: D110124796