[DevTools] Fix commit index reset when switching profiler roots#35672
Merged
[DevTools] Fix commit index reset when switching profiler roots#35672
Conversation
eps1lon
reviewed
Feb 2, 2026
packages/react-devtools-shared/src/devtools/views/Profiler/useCommitFilteringAndNavigation.js
Outdated
Show resolved
Hide resolved
When switching between roots in the profiler flamegraph, the commit index was preserved from the previous root. This caused an error "Invalid commit X. There are only Y commits." when the new root had fewer commits than the selected index. This fix resets the commit index to 0 (or null if no commits) when the commitData changes, which happens when switching roots.
hoxyq
force-pushed
the
fix-profiler-commit-index-on-root-switch
branch
from
394243e to
d8dd1d8
Compare
Contributor
Author
|
Switched to invalidating by keeping commitData in a state and checking referential equality |
eps1lon
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31463, #30114.
When switching between roots in the profiler flamegraph, the commit index was preserved from the previous root. This caused an error "Invalid commit X. There are only Y commits." when the new root had fewer commits than the selected index.
This fix resets the commit index to 0 (or null if no commits) when the commitData changes, which happens when switching roots.