Type react-devtools-hook-installer and react-devtools-hook-settings-injector messages#35586
Merged
eps1lon merged 1 commit intofacebook:mainfrom Jan 21, 2026
Conversation
…s-injector` messages
github-actions
bot
added
the
React Core Team
|
Comparing: b546603...9011a5b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
2 tasks
hoxyq
approved these changes
Jan 21, 2026
eps1lon
deleted the
sebbie/01-21-type_react-devtools-hook-installer_and_react-devtools-hook-settings-injector_messages
branch
This was referenced Jan 22, 2026
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 25, 2026
…s-injector` messages (facebook#35586) DiffTrain build for [cdbd55f](facebook@cdbd55f)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 25, 2026
…s-injector` messages (facebook#35586) DiffTrain build for [cdbd55f](facebook@cdbd55f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially types the message protocol in the content scripts.
The downside is a false sense of safety because we have to restrict the received events to known events. Extending the received events to all possible events would not allow type narrowing.