[linter] Add configuration option to specify hooks that return stable values #33382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: ee76351...494e470 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
… values
Summary:
This commit adds a way to configure the exhaustive deps linter to be aware of user-provided
hooks that return stable values. The configuration allows you to specify the hook name
and optionally a list of property names or indexes that are stable. If no properties
are provided then the outer return value is considered to be stable. If properties
are provided then we allow them to be destructured and determined to be stable.
Please let me know if you have any concerns about the configuration structure:
```typescript
type StableValueHookConfig = Array<{
name: string,
propertiesOrIndexes: null | Array<string> | Array<number>
}>;
```
|
Discussed offline. While some people prefer toomit the deps they know are stable, we're going to instead push people to include those deps anyway. It does not change semantics. This lint ru.e opens more points of failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit adds a way to configure the exhaustive deps linter to be aware of user-provided
hooks that return stable values. The configuration allows you to specify the hook name
and optionally a list of property names or indexes that are stable. If no properties
are provided then the outer return value is considered to be stable. If properties
are provided then we allow them to be destructured and determined to be stable.
Please let me know if you have any concerns about the configuration structure:
Stack created with Sapling. Best reviewed with ReviewStack.