Fix NullPointerException in PromiseImpl.reject by allowing nullable code #54731
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NullPointerException in PromiseImpl.reject
Summary
This PR fixes a
NullPointerExceptionthat occurs whenPromise.rejectis called with anullcode from Java native modules.The issue arises because
Promise.ktandPromiseImpl.ktdefined thecodeparameter as non-nullableStringin several overloads. However,PromiseImpl's internal logic (specifically the catch-allrejectmethod) is designed to handlenullcodes by defaulting toEUNSPECIFIED.When a Java module (such as
react-native-ble-plx) callspromise.reject(null, message), Kotlin's generated null-checks throw aNullPointerExceptionbefore the method body is executed.Changelog
[Android] [Fixed] - Allow nullable
codeinPromise.rejectto prevent NPEs from Java modulesTest Plan
promise.reject(null, "Error message").java.lang.NullPointerException: Parameter specified as non-null is null: method com.facebook.react.bridge.PromiseImpl.reject, parameter code.EUNSPECIFIEDand the app does not crash.Related Issue
Fixes #54722