Remove unnecessary OnBatchCompleteListener
#54685
Open
+2
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87866148. |
Summary: This interface is no longer necessary. It was used in legacy arch to communicate between `UIManagerModule` and `NativeModuleRegistry` This interface was public so I'm marking this as breaking, but I was not able to find any usage in OSS for this interface. Changelog: [Android] [Removed] - Remove unnecessary `OnBatchCompleteListener` used in Legacy Architecture Differential Revision: D87866148
cortinico
force-pushed
the
export-D87866148
branch
from
0137a9a to
b554232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This interface is no longer necessary.
It was used in legacy arch to communicate between
UIManagerModuleandNativeModuleRegistryThis interface was public so I'm marking this as breaking, but I was not able to find any usage in OSS for this interface.
Changelog:
[Android] [Removed] - Remove unnecessary
OnBatchCompleteListenerused in Legacy ArchitectureDifferential Revision: D87866148